Omega359 commented on code in PR #14378:
URL: https://github.com/apache/datafusion/pull/14378#discussion_r1936305090
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -869,54 +867,6 @@ fn get_wider_decimal_type(
}
}
-/// Returns the wider type among arguments `lhs` and `rhs`.
-/// The wider type is the type that can safely represent values from both types
-/// without information loss. Returns an Error if types are incompatible.
-pub fn get_wider_type(lhs: &DataType, rhs: &DataType) -> Result<DataType> {
Review Comment:
The best optimization .. no code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
