alamb commented on code in PR #14379:
URL: https://github.com/apache/datafusion/pull/14379#discussion_r1936332144
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -819,10 +820,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
return not_impl_err!("ANY in LIKE expression");
}
let pattern = self.sql_expr_to_logical_expr(pattern, schema,
planner_context)?;
- let pattern_type = pattern.get_type(schema)?;
Review Comment:
this is the code change -- don't do type checking in the planner
##########
datafusion/sqllogictest/test_files/string/string.slt:
##########
@@ -41,141 +41,6 @@ select arrow_cast(col1, 'Utf8') as c1 from test_substr_base;
#
include ./string_query.slt.part
-# TODO support all String types in sql_like_to_expr and move this test to
`string_query.slt.part`
Review Comment:
By moving these tests to `string_query.slt.part` they now run for strings,
large strings, stringview and dictionary arrays
FYI @goldmedal
##########
datafusion/sqllogictest/test_files/scalar.slt:
##########
@@ -1689,6 +1689,15 @@ true true false false true true
statement ok
drop table t1
+# can't use like with non stirngs
Review Comment:
this shows what happens when you try to run `like` on an integer 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
