alamb commented on PR #1691: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1691#issuecomment-2625826803
> I tried, but there are non-trivial dependencies on the ast:: and dynamic dispatch to the dialect trait. I think it's reasonable to share the ast:: types instead of abstracting them, hence my idea of disabling the parsing from the crate and leave the rest available. The dependencies on the ast can be handled by copying the definitions into DataFusion The dpeendencies on `Dialect` is maybe harder to imagine BTW to be clear the idea in this PR seems fine to me -- I just figured I would comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
