comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1936519276
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -1861,6 +1864,40 @@ fn trim_end(s: &str) -> &str {
}
}
+#[cfg(not(feature = "hdfs"))]
+pub(crate) fn register_object_store(
+ session_context: Arc<SessionContext>,
+) -> Result<(), ExecutionError> {
+ let object_store = object_store::local::LocalFileSystem::new();
+ let url = Url::try_from("file://").unwrap();
+ session_context
+ .runtime_env()
+ .register_object_store(&url, Arc::new(object_store));
+ Ok(())
+}
+
+#[cfg(feature = "hdfs")]
+pub(crate) fn register_object_store(
+ session_context: Arc<SessionContext>,
+) -> Result<(), ExecutionError> {
+ // TODO: read the namenode configuration from file schema or from
spark.defaultFS
+ let url = Url::try_from("hdfs://namenode:9000").unwrap();
Review Comment:
this will be addressed in
https://github.com/apache/datafusion-comet/issues/1360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
