rkrishn7 commented on code in PR #14387:
URL: https://github.com/apache/datafusion/pull/14387#discussion_r1937632262
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1121,6 +1121,39 @@ async fn join() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn join_coercion_unnnamed() -> Result<()> {
+ let ctx = SessionContext::new();
+
+ // Test that join will coerce column types when necessary
+ // even when the relations don't have unique names
Review Comment:
Question: when the columns don't have unique names, is it safe to assume
that the unqualified columns in `left_cols`/`right_cols` refer to the
left/right relations, respectively? Since technically a valid join predicate is
for example, `t1.id = t1.id`.
Seems like it would make sense to me most of the time! But there is some
level of implicitness here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
