gatesn opened a new issue, #14394:
URL: https://github.com/apache/datafusion/issues/14394
### Describe the bug
We were trying to implement a `DataSink` and found that we were being given
different schemas for the record batches than per the RecordBatchStream.
```
STREAM DTYPE Schema { fields: [Field { name: "c1", data_type: Utf8,
nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field {
name: "c2", data_type: Int32, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} }], metadata: {} }
RB SCHEMA: Schema { fields: [Field { name: "c1", data_type: Utf8, nullable:
false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "c2",
data_type: Int32, nullable: false, dict_id: 0, dict_is_ordered: false,
metadata: {} }], metadata: {} }
STREAM DTYPE Schema { fields: [Field { name: "c1", data_type: Utf8,
nullable: false, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field {
name: "c2", data_type: Int32, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} }], metadata: {} }
RB SCHEMA: Schema { fields: [Field { name: "c1", data_type: Utf8, nullable:
true, dict_id: 0, dict_is_ordered: false, metadata: {} }, Field { name: "c2",
data_type: Int32, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
{} }], metadata: {} }
```
The first (correct) invocation comes from assembling a logical plan with
`LogicalPlanBuilder::insert_into`
The second (incorrect) invocation comes from `session.sql("INSERT INTO
my_tbl VALUES ('hello', 42::INT);")`
I figured I'd add an assertion into the RecordBatchStreamAdapter, and it
looks like ~12 tests fail on main right now with mismatched schemas. I wonder
if it's worth adding that as a debug assertion?
https://github.com/gatesn/datafusion/pull/new/ngates/record-batch-stream-schema
cc @AdamGS
### To Reproduce
_No response_
### Expected behavior
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
