jayzhan211 commented on code in PR #14409:
URL: https://github.com/apache/datafusion/pull/14409#discussion_r1938599855
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -614,7 +614,11 @@ pub fn try_type_union_resolution_with_struct(
let mut keys_string: Option<String> = None;
for data_type in data_types {
if let DataType::Struct(fields) = data_type {
- let keys = fields.iter().map(|f| f.name().to_owned()).join(",");
+ let keys = fields
+ .iter()
+ .map(|f| f.name().to_owned())
+ .sorted()
Review Comment:
I think the order matters, reorder doesn't seem correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
