alamb commented on PR #14379: URL: https://github.com/apache/datafusion/pull/14379#issuecomment-2630800635
Thank you @2010YOUY01 -- I have > The change makes sense to me, thank you > > I have one suggestion for additional test: now tests for StringView arrays are included, there are also tests for StringView literals can be added in https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/string/string_literal.slt, like `select 'foo' like arrow_cast('foo', 'Utf8View')` Great idea -- thank you @2010YOUY01 -- done in f138f606e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
