alamb commented on code in PR #14385:
URL: https://github.com/apache/datafusion/pull/14385#discussion_r1939756914
##########
datafusion/sqllogictest/test_files/struct.slt:
##########
@@ -459,14 +459,14 @@ create table t as values({r: 'a', c: 1}), ({r: 'b', c:
2.3});
query ?
select * from t;
----
-{c0: a, c1: 1.0}
Review Comment:
Yes -- these are the field names of the struct type
The values that were written into the table are liek this (a few rows
above). Note the field names are `r` and `c`
```rust
create table t as values({r: 'a', c: 1}), ({r: 'b', c: 2.3});
```
Because they got coerced (1 needed to get coercered to the same type as 2.3)
the field names got reassigned to `c0` and `c1` 🤯 )
The fix in this PR preserves the names from the input which seems much more
correct to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
