blaginin commented on code in PR #14402:
URL: https://github.com/apache/datafusion/pull/14402#discussion_r1939808907
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -559,29 +550,18 @@ impl LastValueAccumulator {
let sort_columns = ordering_values
.iter()
.zip(self.ordering_req.iter())
- .map(|(values, req)| {
- // Take the reverse ordering requirement. This enables us to
- // use "fetch = 1" to get the last value.
- SortColumn {
- values: Arc::clone(values),
- options: Some(!req.options),
- }
+ .map(|(values, req)| SortColumn {
+ values: Arc::clone(values),
+ options: Some(req.options),
})
.collect::<Vec<_>>();
- if self.ignore_nulls {
- let indices = lexsort_to_indices(&sort_columns, None)?;
- // If ignoring nulls, find the last non-null value.
- for index in indices.iter().flatten() {
- if !value.is_null(index as usize) {
- return Ok(Some(index as usize));
- }
- }
- Ok(None)
- } else {
- let indices = lexsort_to_indices(&sort_columns, Some(1))?;
- Ok((!indices.is_empty()).then_some(indices.value(0) as _))
- }
+ let comparator = LexicographicalComparator::try_new(&sort_columns)?;
+ let best = (0..value.len())
+ .filter(|&index| !(self.ignore_nulls && value.is_null(index)))
Review Comment:
thank you, updated in
https://github.com/apache/datafusion/pull/14402/commits/c56517db340428d2dae5a7d1ea425dfa2fd5b4cb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
