alamb commented on code in PR #14464:
URL: https://github.com/apache/datafusion/pull/14464#discussion_r1941705612
##########
datafusion/core/src/datasource/listing/mod.rs:
##########
@@ -18,263 +18,6 @@
//! A table that uses the `ObjectStore` listing capability
//! to get the list of files to process.
-mod helpers;
mod table;
-mod url;
-
-use chrono::TimeZone;
-use datafusion_common::Result;
-use datafusion_common::{ScalarValue, Statistics};
-use futures::Stream;
-use object_store::{path::Path, ObjectMeta};
-use std::pin::Pin;
-use std::sync::Arc;
-
-pub use self::url::ListingTableUrl;
+pub use datafusion_catalog_listing::*;
Review Comment:
💯
##########
datafusion/catalog-listing/src/helpers.rs:
##########
@@ -569,218 +580,6 @@ mod tests {
assert_eq!(0, chunks.len());
}
- #[tokio::test]
- async fn test_pruned_partition_list_empty() {
Review Comment:
Theses tests look like unit tests to me (they are are for
`pruned_partition_list` which is defined in this module
I looked at `make_test_store_and_state` and it seems to me like it is fairly
simple and could be copy/pasted into this `test` module to avoid a new
dependency.
Would you be ok with doing that? I can also push a commit to this PR if it
is good with you
##########
datafusion/core/tests/core_integration.rs:
##########
@@ -46,6 +46,8 @@ mod physical_optimizer;
mod catalog;
+mod catalog_listing;
Review Comment:
👍
##########
datafusion/catalog-listing/README.md:
##########
@@ -0,0 +1,30 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# DataFusion catalog-listing
+
+[DataFusion][df] is an extensible query execution framework, written in Rust,
that uses Apache Arrow as its in-memory format.
Review Comment:
I pushed a commit to improve this README content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
