hansott opened a new pull request, #1705: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1705
- Docs https://dev.mysql.com/doc/refman/8.4/en/ansi-diff-comments.html - Lexer https://github.com/mysql/mysql-server/blob/trunk/sql/sql_lex.cc#L1465-L1472 - Char checks ```cpp static constexpr uint8_t MY_CHAR_CTR = 040; /* Control character */ inline bool my_iscntrl(const CHARSET_INFO *cs, char ch) { return ((cs->ctype + 1)[static_cast<uint8_t>(ch)] & MY_CHAR_CTR) != 0; } static constexpr uint8_t MY_CHAR_SPC = 010; /* Spacing character */ inline bool my_isspace(const CHARSET_INFO *cs, char ch) { return ((cs->ctype + 1)[static_cast<uint8_t>(ch)] & MY_CHAR_SPC) != 0; } ``` It's not super clear which characters belong to `my_iscntrl` and `my_isspace` but we cannot use `char.is_whitespace()` as it includes `'\n'`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
