zhuqi-lucas commented on code in PR #14499: URL: https://github.com/apache/datafusion/pull/14499#discussion_r1942519687
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5032,18 +5032,17 @@ logical_plan 03)----Aggregate: groupBy=[[aggregate_test_100.c3]], aggr=[[min(aggregate_test_100.c1)]] 04)------TableScan: aggregate_test_100 projection=[c1, c3] physical_plan -01)GlobalLimitExec: skip=0, fetch=5 Review Comment: It looks like the SKIP setting is not supported for all with_fetch operators, for example: SortPreservingMergeExec also support fetch but not support setting skip, it's default to 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
