berkaysynnada opened a new issue, #14505:
URL: https://github.com/apache/datafusion/issues/14505

   ### Is your feature request related to a problem or challenge?
   
   Both WindowAggExec and BoundedWindowAggExec has a field of 
   ```
       /// Partition Keys
       pub partition_keys: Vec<Arc<dyn PhysicalExpr>>,
   ```
   They already have also 
   ```
       /// Window function expression
       window_expr: Vec<Arc<dyn WindowExpr>>,
   ```
   and these WindowExpr's are providing the API of:
   ```
       /// Expressions that's from the window function's partition by clause, 
empty if absent
       fn partition_by(&self) -> &[Arc<dyn PhysicalExpr>];
   ```
   
   ### Describe the solution you'd like
   
   If I am not mistaken, the execs' itself can avoid including these 
partition_by expression, and can access it over window_expr's. 
   
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   Unless someone warns that these are used for different purposes and can 
differ, then I'll close the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to