goldmedal commented on code in PR #14474:
URL: https://github.com/apache/datafusion/pull/14474#discussion_r1942781864
##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -1609,13 +1616,14 @@ mod tests {
.build()?;
// not optimized
Review Comment:
I guess that it's also out of date 🤔 ?
##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -389,19 +389,25 @@ where o_orderstatus in (
2
3
+# uncorrelated exists
+query I
+SELECT 1 WHERE EXISTS (SELECT 1)
+----
+1
+
#exists_subquery_with_same_table
#Subquery and outer query refer to the same table.
#It will not be rewritten to join because it is not a correlated subquery.
Review Comment:
Is this comment out of date? I guess we expect to rewrite it to a semi-join
now (?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
