findepi commented on code in PR #14513:
URL: https://github.com/apache/datafusion/pull/14513#discussion_r1943107037
##########
datafusion/functions/src/utils.rs:
##########
@@ -18,10 +18,27 @@
use arrow::array::ArrayRef;
use arrow::datatypes::DataType;
-use datafusion_common::{Result, ScalarValue};
+use datafusion_common::{exec_datafusion_err, Result, ScalarValue};
use datafusion_expr::function::Hint;
use datafusion_expr::ColumnarValue;
+/// Converts a collection of function arguments into an fixed-size array of
length N
+/// producing a reasonable error message in case of unexpected number of
arguments.
Review Comment:
> I suggest we publically export util and this method too
>
> Can of course be done in a follow on PR
will do. utils has only pub(crate) members, so we're not exporting more than
just this func
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
