comphead commented on code in PR #14519:
URL: https://github.com/apache/datafusion/pull/14519#discussion_r1945425102
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -689,7 +693,7 @@ impl DefaultPhysicalPlanner {
if physical_field.data_type() !=
logical_field.data_type() {
differences.push(format!("field data type at index
{} [{}]: (physical) {} vs (logical) {}", i, physical_field.name(),
physical_field.data_type(), logical_field.data_type()));
}
- if physical_field.is_nullable() !=
logical_field.is_nullable() {
+ if physical_field.is_nullable() &&
!logical_field.is_nullable() {
Review Comment:
like it! I still don't get why we still check nullability in schemas
equivalence, 🤔 logical a physical schema can be derived differently and
nullable sometimes derived in different way as well.
Nullability checks was a source of dozens problems on schema mismatch
especially for UNION
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
