2010YOUY01 commented on code in PR #14534: URL: https://github.com/apache/datafusion/pull/14534#discussion_r1945987503
########## datafusion/physical-plan/src/sorts/mod.rs: ########## @@ -19,12 +19,9 @@ mod builder; mod cursor; -mod index; mod merge; pub mod partial_sort; pub mod sort; pub mod sort_preserving_merge; mod stream; pub mod streaming_merge; - -pub use index::RowIndex; Review Comment: This is a public struct, we should deprecate it first https://datafusion.apache.org/library-user-guide/api-health.html By the way, I'm curious is there a way we can detect such unused structs in CI 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
