alamb commented on code in PR #14561:
URL: https://github.com/apache/datafusion/pull/14561#discussion_r1948062976
##########
datafusion/proto/src/bytes/mod.rs:
##########
@@ -199,11 +199,7 @@ pub fn logical_plan_to_bytes(plan: &LogicalPlan) ->
Result<Bytes> {
#[cfg(feature = "json")]
pub fn logical_plan_to_json(plan: &LogicalPlan) -> Result<String> {
let extension_codec = DefaultLogicalExtensionCodec {};
- let protobuf =
- protobuf::LogicalPlanNode::try_from_logical_plan(plan,
&extension_codec)
- .map_err(|e| plan_datafusion_err!("Error serializing plan: {e}"))?;
- serde_json::to_string(&protobuf)
- .map_err(|e| plan_datafusion_err!("Error serializing plan: {e}"))
+ logical_plan_to_json_with_extension_codec(plan, &extension_codec)
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
