eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1948557193
##########
datafusion/sql/tests/cases/diagnostic.rs:
##########
@@ -201,14 +201,8 @@ fn test_ambiguous_reference() -> Result<()> {
let diag = do_query(query);
assert_eq!(diag.message, "column 'first_name' is ambiguous");
assert_eq!(diag.span, Some(spans["a"]));
- assert_eq!(
- diag.notes[0].message,
- "possible reference to 'first_name' in table 'a'"
- );
- assert_eq!(
- diag.notes[1].message,
- "possible reference to 'first_name' in table 'b'"
- );
+ assert_eq!(diag.notes[0].message, "possible column a.first_name");
+ assert_eq!(diag.notes[1].message, "possible column b.first_name");
Review Comment:
Ok if you say non-exact matches should be shown too, I'm on board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
