parthchandra commented on code in PR #1384:
URL: https://github.com/apache/datafusion-comet/pull/1384#discussion_r1950074930
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -862,7 +862,7 @@ class CometSparkSessionExtensions
newOp match {
case Some(nativeOp) =>
s.child match {
- case n if n.isInstanceOf[CometNativeExec] ||
!n.supportsColumnar =>
+ case n if n.isInstanceOf[CometNativeExec] ||
n.supportsColumnar =>
Review Comment:
If the child is not a `CometNativeExec` can be be a `ShuffleExchangeExec`?
In that case we should not use `CometColumnarShuffle`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
