jayzhan211 commented on code in PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#discussion_r1950125583
##########
datafusion/functions-nested/src/remove.rs:
##########
@@ -98,7 +99,7 @@ impl ScalarUDFImpl for ArrayRemove {
}
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
- Ok(arg_types[0].clone())
+ Ok(coerced_fixed_size_list_to_list(&arg_types[0]))
Review Comment:
If we coerce types in `return_type` then a question comes out, what coercion
should be handled before `return_type` and what should be handled inside
`return_type`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
