kazuyukitanimura commented on code in PR #1377:
URL: https://github.com/apache/datafusion-comet/pull/1377#discussion_r1950410368
##########
.github/actions/rust-test/action.yaml:
##########
@@ -29,7 +29,7 @@ runs:
shell: bash
run: |
cd native
- cargo clippy --color=never --all-targets --workspace -- -D warnings
+ cargo clippy --color=never --all-targets --workspace --exclude
datafusion-objectstore-hdfs -- -D warnings
Review Comment:
any specific reason for excluding hdfs?
##########
native/core/Cargo.toml:
##########
@@ -78,6 +78,7 @@ object_store = { workspace = true }
url = { workspace = true }
chrono = { workspace = true }
parking_lot = "0.12.3"
+datafusion-objectstore-hdfs = { path = "../hdfs", optional = true}
Review Comment:
So the `core` needs `hdfs`? then should we place it under `native/core/hdfs`
rather than `native/hdfs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
