zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1951159851


##########
datafusion/sqllogictest/test_files/aggregate_skip_partial.slt:
##########
@@ -228,6 +231,27 @@ CREATE TABLE aggregate_test_100_null (
   c11 FLOAT
 );
 
+statement error DataFusion error: Error during planning: Inserting query must 
have the same schema nullability as the table\. Expected table field 'c5' 
nullability: false, got field: 'c5', nullability: true
+INSERT INTO aggregate_test_100_null
+SELECT
+  c2,
+  c5,
+  CASE WHEN c1 = 'e' THEN NULL ELSE c3 END as c3,
+  CASE WHEN c1 = 'a' THEN NULL ELSE c11 END as c11
+FROM aggregate_test_100;
+
+statement ok
+drop table aggregate_test_100_null;
+
+# Test successful insert case which c5 is nullable
+statement ok
+CREATE TABLE aggregate_test_100_null (
+  c2  TINYINT NOT NULL,
+  c5  INT,

Review Comment:
   Noted, i also add the successful case which the c5 is nullable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to