benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953347665
##########
src/ast/operator.rs:
##########
@@ -253,6 +268,40 @@ pub enum BinaryOperator {
/// Specifies a test for an overlap between two datetime periods:
///
<https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#overlaps-predicate>
Overlaps,
+ /// `##` Point of closest proximity (PostgreSQL/Redshift geometric
operator), e.g. `point '(0,0)' ## lseg '((2,0),(0,2))'`
+ PointOfClosestProximity,
+ /// `<->` Distance between (PostgreSQL/Redshift geometric operator), e.g.
`circle '((0,0),1)' <-> circle '((5,0),1)'`
+ DistanceBetween,
+ /// `&&` Overlaps? (PostgreSQL/Redshift geometric operator), e.g. box
'((0,0),(1,1))' && box '((0,0),(2,2))'
Review Comment:
no, there was one commented out, I removed it.
##########
src/keywords.rs:
##########
@@ -141,6 +141,7 @@ define_keywords!(
BOOL,
BOOLEAN,
BOTH,
+ BOX, // PostgreSQL/Redshift geometry type, rectangular box
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]