Kontinuation opened a new pull request, #14642:
URL: https://github.com/apache/datafusion/pull/14642

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #14641.
   
   ## Rationale for this change
   
   I had to run sort-tpch queries with memory limit when testing fixes for 
memory related issues, so I decide to add `--memory-limit` option for most of 
the benchmarking cli tools. I wish other developers could find it handy.
   
   ## What changes are included in this PR?
   
   This PR adds 2 cli options `--memory-limit` and `--mem-pool-type` to the 
following benchmarking tools:
   
   * `dfbench`
   * `sort_tpch`
   * `imdb`
   
   `external_aggr` already supports `--memory-limit`, it now accepts 
`--mem-pool-type`. The default value of `--mem-pool-type` is `fair` so the 
behavior remains unchanged.
   
   ## Are these changes tested?
   
   The changes were tested manually.
   
   ## Are there any user-facing changes?
   
   No. The benchmarking guide has not covered every option so hopefully the 
developers could find these options themselves using `--help`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to