EmilyMatt commented on PR #1390: URL: https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2656455632
@andygrove I've updated "test final min/max/count with result expressions" in the Aggregate suite to verify this more deeply, and I think many of the queries in the stability tests also have this issue. The current implementation does not crash or anything but just converts the intermediate results back to Spark so they can be used in the Spark HashAggregate. With this PR the aggregate will be fully native so hopefully this will be a performance boost. I think a crash will be encountered in any Aggregate that uses an aggregate buffer, as the Partial CometHashAggregate will not generate the expected IntermediateAggBuffer representation Spark expects, and possibly not even the same data type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
