andygrove commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1954812215
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -1352,6 +1352,15 @@ object CometSparkSessionExtensions extends Logging {
org.apache.spark.SPARK_VERSION >= "4.0"
}
+ def isComplexTypeReaderEnabled(conf: SQLConf): Boolean = {
Review Comment:
I find the naming confusing here. This method determines if we are using
`native_datafusion` or `native_iceberg_compat` (which both use DataFusion's
`ParquetExec`). This is no logic related to complex types.
Complex type support was a big motivation for adding these new scans, but it
doesn't seem to make sense to refer to complex types in the changes in this PR.
This is just a nit, and we can rename the methods in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
