lewiszlw commented on code in PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#discussion_r1955511641
##########
datafusion/physical-plan/src/aggregates/order/partial.rs:
##########
@@ -103,47 +102,46 @@ enum State {
Complete,
}
+impl State {
+ fn size(&self) -> usize {
+ match self {
+ State::Taken => 0,
+ State::Start => 0,
+ State::InProgress { sort_key, .. } => sort_key
+ .iter()
+ .map(|scalar_value| scalar_value.size())
+ .sum(),
+ State::Complete => 0,
+ }
+ }
+}
+
impl GroupOrderingPartial {
pub fn try_new(
- input_schema: &Schema,
+ _input_schema: &Schema,
Review Comment:
Why not remove this arg?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
