simonvandel opened a new pull request, #14675:
URL: https://github.com/apache/datafusion/pull/14675
## Which issue does this PR close?
N/A
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
It seems to be faster to generate random u128's in bulk, and then converting
them to Uuids.
However, we are not exactly using the same random number generator.
`Uuid::new_v4()` is using `getrandom`. In this PR, we are using `rand`.
```
$ cargo bench -p datafusion-functions --bench uuid
uuid time: [36.797 µs 36.910 µs 37.028 µs]
change: [-95.589% -95.576% -95.563%] (p = 0.00 <
0.05)
Performance has improved.
```
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes, existing tests
## Are there any user-facing changes?
Yes, faster uuid() UDF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
