blaginin commented on code in PR #14636:
URL: https://github.com/apache/datafusion/pull/14636#discussion_r1957123673
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1801,7 +1801,8 @@ impl DataFrame {
.iter()
.map(|(qualifier, field)| {
if qualifier.eq(&qualifier_rename) && field.as_ref() ==
field_rename {
- col(Column::from((qualifier, field))).alias(new_name)
+ col(Column::from((qualifier, field)))
+ .alias_qualified(qualifier.cloned(), new_name)
Review Comment:
Thanks for the review! The idea of that PR is to speed up adding new columns
by not doing normalization if it is not needed - that happens if `relation` is
already set. By calling `alias_qualified` I set the relation which allows me to
exit early later 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
