alamb commented on code in PR #14695:
URL: https://github.com/apache/datafusion/pull/14695#discussion_r1957309589
##########
datafusion/expr/src/udaf.rs:
##########
@@ -382,6 +390,45 @@ pub trait AggregateUDFImpl: Debug + Send + Sync {
/// Returns this function's name
fn name(&self) -> &str;
+ /// Returns the name of the column this expression would create
+ ///
+ /// See [`Expr::schema_name`] for details
Review Comment:
It would be nice if this documentation included an example of the output too
##########
datafusion/expr/src/expr.rs:
##########
@@ -2264,35 +2279,15 @@ impl Display for SchemaDisplay<'_> {
| Expr::Placeholder(_)
| Expr::Wildcard { .. } => write!(f, "{}", self.0),
- Expr::AggregateFunction(AggregateFunction {
- func,
- args,
- distinct,
- filter,
- order_by,
- null_treatment,
- }) => {
- write!(
- f,
- "{}({}{})",
- func.name(),
- if *distinct { "DISTINCT " } else { "" },
- schema_name_from_exprs_comma_separated_without_space(args)?
- )?;
-
- if let Some(null_treatment) = null_treatment {
- write!(f, " {}", null_treatment)?;
+ Expr::AggregateFunction(AggregateFunction { func, params }) => {
+ match func.schema_name(params) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
