alamb commented on code in PR #14693:
URL: https://github.com/apache/datafusion/pull/14693#discussion_r1957309927
##########
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##########
@@ -518,16 +514,12 @@ impl ScalarUDFImpl for AddIndexToStringVolatileScalarUDF {
Ok(self.return_type.clone())
}
- fn invoke_batch(
- &self,
- args: &[ColumnarValue],
- number_rows: usize,
- ) -> Result<ColumnarValue> {
- let answer = match &args[0] {
+ fn invoke_with_args(&self, args: ScalarFunctionArgs) ->
Result<ColumnarValue> {
+ let answer = match &args.args[0] {
Review Comment:
As a minor follow up, this could use `take_function_args`
https://github.com/apache/datafusion/blob/2d303346c7d44a78d317e7b7b959cbd94edfb891/datafusion/functions-aggregate/src/sum.rs#L130-L129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
