alamb commented on PR #14671: URL: https://github.com/apache/datafusion/pull/14671#issuecomment-2661554615
> @alamb, I have implemented a MockMemorySourceConfig and MockDataSource which is essentially same as what was previously in physical_plan but now for tests only. You can find the implementation [here](https://github.com/logan-keede/datafusion/tree/explore_Mock). The tests are passing on my PC, although there are some warnings, so cleaning up that part is still pending. > > I think this is different from what you were suggesting. It would be pretty helpful if you can point me in the right direction. > > Thanks, Logan I think this sounds reasonable -- I was just saying that the split between `MockMemorySourceConfig` and `MockDataSource` is likely not necessary. There is a split in the current `DataSourceConfig` and `DataSourceExec` to permit sharing between difefrent data sources -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
