Blizzara commented on issue #14652: URL: https://github.com/apache/datafusion/issues/14652#issuecomment-2663058496
Just FYI: As I note in https://github.com/apache/datafusion/issues/14729, it seems rust (neither compile nor clippy) doesn't warn about _implementing_ a deprecated method, only _calling_ it. As such, the eventual removal of `invoke_batch` will be a sudden compile-time break for anyone who's not manually checking changelogs. I'm not saying it shouldn't be removed, I do think code needs to be able to evolve - just flagging this as it came as surprise to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
