goldmedal commented on code in PR #14726:
URL: https://github.com/apache/datafusion/pull/14726#discussion_r1958473136
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -120,11 +120,11 @@ impl ScalarUDFImpl for ArrayHas {
Ok(DataType::Boolean)
}
- fn invoke_batch(
+ fn invoke_with_args(
&self,
- args: &[ColumnarValue],
- _number_rows: usize,
+ args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
+ let args = &args.args;
Review Comment:
minor: this could use `take_function_args`
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -286,11 +285,11 @@ impl ScalarUDFImpl for StringToArray {
})
}
- fn invoke_batch(
+ fn invoke_with_args(
&self,
- args: &[ColumnarValue],
- _number_rows: usize,
+ args: datafusion_expr::ScalarFunctionArgs,
) -> Result<ColumnarValue> {
+ let args = &args.args;
Review Comment:
this could use take_function_args, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
