tustvold commented on issue #12720: URL: https://github.com/apache/datafusion/issues/12720#issuecomment-2663546158
> keeps ScalarValue::Utf8(String) for performance reason, given it is more lightweight compare than Scalar<ArrayRef> IMO ScalarValue shouldn't ever be on the hot path, if it is it indicates an issue with the way that kernel has been implemented. It has been a while since I looked at DF, but it did use to be a lot of the windowed aggregates and array functions were using ScalarValue when they probably shouldn't have been IMO unless it is arrow kernels that are bottlenecked on ScalarValue::Utf8 it wouldn't make sense to push this into arrow-rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
