andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1958492751
##########
.github/actions/setup-spark-builder/action.yaml:
##########
@@ -46,7 +42,6 @@ runs:
run: |
cd apache-spark
git apply ../dev/diffs/${{inputs.spark-version}}.diff
- ../mvnw -nsu -q versions:set-property -Dproperty=comet.version
-DnewVersion=${{inputs.comet-version}} -DgenerateBackupPoms=false
Review Comment:
This was hiding the fact that we had an incorrect version in the diff files.
Now that this is removed, CI will fail if we do not have the correct version in
the diff files, which is good since we want depend on these files having the
correct version when running the Spark SQL tests locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
