westonpace commented on PR #14644: URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2664703991
Thanks for the ping and thanks for working on this! This is an important feature for us (for training secondary indices on string columns) so I'm very thankful to see the effort :smile: I tried the reproducer from on this branch (babe5cdf512062c6e8f5b830570ba233bb138026) and wasn't able to get it to pass and so I agree it doesn't seem to address all issues. However, what you're describing does seem to address the problems that I was seeing and so I think it probably is making good progress. I also tried setting `session_config.options_mut().execution.parquet.schema_force_view_types = false;` and various values of `sort_spill_reservation_bytes` but didn't have much luck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
