niebayes commented on code in PR #14723:
URL: https://github.com/apache/datafusion/pull/14723#discussion_r1960092759
##########
datafusion/substrait/src/serializer.rs:
##########
@@ -26,28 +26,50 @@ use substrait::proto::Plan;
use std::fs::OpenOptions;
use std::io::{Read, Write};
+use std::path::Path;
-#[allow(clippy::suspicious_open_options)]
-pub async fn serialize(sql: &str, ctx: &SessionContext, path: &str) ->
Result<()> {
+/// Plans a sql and serializes the generated logical plan to bytes.
+/// The bytes are then written into a file at `path`.
+///
+/// Returns an error if the file already exists and is not empty.
+pub async fn serialize(
+ sql: &str,
+ ctx: &SessionContext,
+ path: impl AsRef<Path>,
+) -> Result<()> {
let protobuf_out = serialize_bytes(sql, ctx).await;
- let mut file = OpenOptions::new().create(true).write(true).open(path)?;
+
+ if std::fs::metadata(path.as_ref()).is_ok_and(|meta| meta.len() > 0) {
+ return Err(DataFusionError::Substrait(format!(
+ "Failed to encode plan: the file {} already exists and is not
empty",
+ path.as_ref().display()
+ )));
+ }
+
+ let mut file = OpenOptions::new()
+ .create(true)
+ .write(true)
+ .truncate(true)
+ .open(path)?;
Review Comment:
@mbrobbel Didn't consider the atomicity, good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
