alamb commented on code in PR #14750:
URL: https://github.com/apache/datafusion/pull/14750#discussion_r1961585600
##########
datafusion/expr/src/expr.rs:
##########
@@ -2621,33 +2650,47 @@ impl Display for Expr {
// Expr::ScalarFunction(ScalarFunction { func, args }) => {
// write!(f, "{}", func.display_name(args).unwrap())
// }
- Expr::WindowFunction(WindowFunction {
- fun,
- args,
- partition_by,
- order_by,
- window_frame,
- null_treatment,
- }) => {
- fmt_function(f, &fun.to_string(), false, args, true)?;
-
- if let Some(nt) = null_treatment {
- write!(f, "{}", nt)?;
+ Expr::WindowFunction(WindowFunction { fun, params }) => match fun {
+ WindowFunctionDefinition::AggregateUDF(fun) => {
+ match fun.window_function_display_name(params) {
+ Ok(name) => {
+ write!(f, "{}", name)
+ }
+ Err(e) => {
+ write!(f, "got error from
window_function_display_name {}", e)
Review Comment:
for any other reviewer, this seems weird but it is consistent with the other
code in `Display` -- and the `Display` impl can't return an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
