zhuqi-lucas commented on code in PR #14766: URL: https://github.com/apache/datafusion/pull/14766#discussion_r1961832072
########## datafusion-cli/src/main.rs: ########## @@ -121,6 +121,13 @@ struct Args { )] maxrows: MaxRows, + #[clap( + short, + long, + help = "Whether to stop early when max rows is reached, this will help reduce the memory usage when the result is large" Review Comment: Very good point, remove it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org