berkaysynnada commented on code in PR #14699:
URL: https://github.com/apache/datafusion/pull/14699#discussion_r1963770340
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -1119,11 +1180,11 @@ fn next_value_helper<const INC: bool>(value:
ScalarValue) -> ScalarValue {
match value {
// f32/f64::NEG_INF/INF and f32/f64::NaN values should not emerge at
this point.
Float32(Some(val)) => {
- assert!(val.is_finite(), "Non-standardized floating point usage");
+ debug_assert!(val.is_finite(), "Non-standardized floating point
usage");
Review Comment:
Similar to other debug_assert!'s, it cannot happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
