gabotechs commented on code in PR #14412: URL: https://github.com/apache/datafusion/pull/14412#discussion_r1963954221
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100 ---- NULL +query T +SELECT STRING_AGG(DISTINCT x,',') FROM strings WHERE g > 100 Review Comment: 🤷♂️ It's the format that all the previous tests were following, I kept it for consistency ########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -5568,6 +5573,16 @@ SELECT STRING_AGG(x,',') FROM strings WHERE g > 100 ---- NULL +query T +SELECT STRING_AGG(DISTINCT x,',') FROM strings WHERE g > 100 Review Comment: 🤷♂️ It's the format that all the previous STRING_AGG tests were following, I kept it for consistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
