iajoiner opened a new pull request, #1736:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1736
The only warning I got was
```bash
warning: relative drop order changing in Rust 2024
--> src/test_utils.rs:305:11
|
304 | let mut iter = v.into_iter();
| --------
| |
| `iter` calls a custom destructor
| `iter` will be dropped later as of Edition 2024
305 | match (iter.next(), iter.next()) { (Some(item), None) => {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| this value will be stored in a temporary; let us call it `#1`
| up until Edition 2021 `#1` is dropped last but will be
dropped earlier in Edition 2024
...
310 | }
| - now the temporary value is dropped here, before the local variables
in the block or statement
|
= warning: this changes meaning in Rust 2024
= note: for more information, see
<https://doc.rust-lang.org/nightly/edition-guide/rust-2024/temporary-tail-expr-scope.html>
= note: most of the time, changing drop order is harmless; inspect the
`impl Drop`s for side effects like releasing locks or sending messages
= note: `--force-warn tail-expr-drop-order` implied by `--force-warn
rust-2024-compatibility`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
