jayzhan211 commented on PR #14668: URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2673054919
> I don't have expectations that generic implementation will be faster than 50x[1](https://github.com/apache/datafusion/pull/14668#user-content-fn-1-8db9f2d544d304aebaed47866e77cf69) longer, hand-written and optimized code. Rather, I wanted to check what can be a performance difference between simple 4-liner implementation and one that has dedicated code paths for ascii/unicode, nulls/non-nulls and Utf8/Utf8View combinations. I.e. anything but not "simple". Interesting, I will review it when I have time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
