waynr opened a new pull request, #14805: URL: https://github.com/apache/datafusion/pull/14805
- **chore(temporary): patch objectstore with local path** - **feat: implement ContextualizedObjectStore that passes along session state via GetOptions** - **chore: update temporary object_store patch rev** ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - [ ] Closes https://github.com/apache/datafusion/issues/14804. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> See https://github.com/apache/datafusion/issues/14804 ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Introduce new `ContextualizedObjectStore` type that implements `object_store::ObjectStore`. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> I haven't written any tests for this behavior in datafusion yet and would like guidance from maintainers with respect to what kind of testing they think would be good here. I also still need to manually test that this does the thing I want it to do with respect to tracing in a caching `ObjectStore` implementation in https://github.com/influxdata/influxdb ## Are there any user-facing changes? Only if the user registers a custom `ObjectStore` implementation with datafusion and wants to pass opaque data (like tracing spans) from various places in the call stack leading up to query execution -- after this they will have access to that data in their custom implementation of `ObjectStore.get_opts` when called during query execution. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
