alamb commented on code in PR #14802: URL: https://github.com/apache/datafusion/pull/14802#discussion_r1965384145
########## datafusion/ffi/src/execution_plan.rs: ########## @@ -372,6 +379,51 @@ mod tests { assert!(original_name == foreign_plan.name()); + let display = datafusion::physical_plan::display::DisplayableExecutionPlan::new( + &foreign_plan, + ); + + let mut buf = String::new(); + write!(&mut buf, "{}", display.one_line()).unwrap(); + let buf = buf.trim(); Review Comment: I think you can probably do this more succintly using `to_string()` Something like this (untested): ```suggestion let buf = display.one_line().to_string().trim(); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org