wiedld opened a new pull request, #14821:
URL: https://github.com/apache/datafusion/pull/14821

   ## Which issue does this PR close?
   
   No issue. 
   
   ## Rationale for this change
   
   It's a minor refactor on the `EnforceSorting` subrule `sort_pushdown`. I was 
having a hard time reasoning and debugging a few things -- turning into our 
standard visitor pattern (`transform_down`) made it a lot easier for me.
   
   
   ## What changes are included in this PR?
   
   Move `pushdown_sorts` to use the standard top-down traversal.
   Only requires a bit of tweaking in the `pushdown_sorts_helper`.
   Add copious code docs.
   
   
   ## Are these changes tested?
   
   Yes, with existing tests.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to