alamb commented on PR #14689: URL: https://github.com/apache/datafusion/pull/14689#issuecomment-2676180834
> > Making extended tests optional BUT easily visible and run it before merge (maybe github supports such UI?) seems like a better approach. > > If this is possible, certainly. If not, we will need to fall back to the old run-everything mode until we figure out a way to implement something like this. The downside is that the "sqllogictests" thing takes 2 hours to run (and it takes quite a while to run even locally) > Having broken main commits frequently is not a sustainable practice. Yeah, I agree The upside of the current approach is that at least now we know there is an issue that was introduced. > I had hoped we would be able to run the extended suite on PRs by now - https://github.com/apache/datafusion/issues/14319 @buraksenn has some version of it here, but it was not working - https://github.com/apache/datafusion/pull/14331 I'll see if I can get someone to help out to make it work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
